Restrict installed apps upgrade #13086
Open
+291
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2025 16:14
momesgin
commented
Jan 15, 2025
| if ( preferRepoType && preferRepoName ) { | ||
| preferSameRepo(matching, preferRepoType, preferRepoName); | ||
| if (multiple) { | ||
| return matchingCharts; | ||
| } |
There was a problem hiding this comment.
this's been removed since it was not being used anymore
momesgin
commented
Jan 15, 2025
|
|
||
| // Filtering matches by verifying if the current version is in the matched chart's available versions, and that the home value matches as well | ||
| const thisHome = chart?.metadata?.home; | ||
| const bestMatches = matchingCharts.filter((m) => m.versions.some((v) => v.version === this.currentVersion && v.home === thisHome)); |
There was a problem hiding this comment.
@nwmac as we discussed, I've updated the filtering logic, and it seems to be working well. The only drawback is that it's a bit expensive since it requires iterating through the versions array.
There was a problem hiding this comment.
I've optimized the iteration through versions a bit
added 4 commits
January 15, 2025 08:40
added 3 commits
January 21, 2025 16:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11679 and #11680
Occurred changes and/or fixed issues
upgradeAvailableto a more meaningful and readable formatcatalog/chartin the store to let returning multiple matching chartsmatchingChartnow looks into the versions array of a matched chart to make sure it's a right match. Since a version is like a snapshot in time, it'll be safe to check thehomevalue against it for an installed appAreas or cases that should be tested
Unit tests are added to cover different cases for the new approach, but manual tests would be great to make sure it's working as expected.
Make sure
cert-manager1.7.1 is installed by CLI. Then add OCI repo for AppCo. Go to the installed apps page and make sure there's no upgrade available.Areas which could experience regressions
Install an old version of any apps. Go to the Installed apps page, and check the upgrade is available.
Checklist